Skip to content

Issue 2577: enable lexical-only findAndRerank (i.e. no-vector/ize one-leg retrieval path) - #2579

Open
sl-at-ibm wants to merge 2 commits into
mainfrom
SL-issue-2577-missing-vectorIze-in-farr
Open

Issue 2577: enable lexical-only findAndRerank (i.e. no-vector/ize one-leg retrieval path)#2579
sl-at-ibm wants to merge 2 commits into
mainfrom
SL-issue-2577-missing-vectorIze-in-farr

Conversation

@sl-at-ibm

@sl-at-ibm sl-at-ibm commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

What this PR does:

Address #2577 under the assumption that symmetry is preferrable (between vector/ize-only and lexical-only paths for f.A.R.R.)

In other words, rather than better dressing the error mentioned in the issue (no vector/ize provided => illegal arg exception), it accepts a findAndRerank with the lexical part only in $hybrid, executes that leg of the retrieval, and submits those results to the reranker.

Note: this PR is kept intentionally clear of fixing the absence of "rerankOn" (these two errors are close to each other). This is to avoid overlapping with #2578 which deals with that issue. If that other ever gets merged, it might be a good idea to add a test to this one for the case with lexical-only and no rerankOn.

Which issue(s) this PR fixes:

Fixes #2577

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • [n/a] Documentation added/updated
  • [n/a] CLA Signed: DataStax CLA

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 53.40%
This PR 53.45%
Delta 🟢 +0.04%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 53.45% 🍏
Files changed 98.08% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 83.95% -0.13% 🍏

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 71.45%
This PR 71.45%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 71.45% -0.01% 🍏
Files changed 76.92% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 84.22% -1.59% 🍏

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.76%
This PR 72.77%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 72.77% 🍏
Files changed 90.38% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 90.85% -0.66% 🍏

@sl-at-ibm
sl-at-ibm marked this pull request as ready for review September 9, 2026 20:40
@sl-at-ibm
sl-at-ibm requested a review from a team as a code owner September 9, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IllegalArgumentException / UNEXPECTED_SERVER_ERROR in FindAndRerank when omitting $vectorize in $hybrid

1 participant